[PATCH] ppc64: Updated Olof iommu updates 2/3

[will schmidt]

Olof Johansson wrote:
> On Tue, Sep 20, 2005 at 03:35:23PM +1000, Stephen Rothwell wrote:
> 
>>On Tue, 20 Sep 2005 13:46:44 +1000 Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
>>
>>>@@ -167,7 +176,7 @@
>>> 		 * Set up the page with TCE data, looping through and setting
>>> 		 * the values.
>>> 		 */
>>>-		limit = min_t(long, npages, PAGE_SIZE/sizeof(union tce_entry));
>>>+		limit = min_t(long, npages, 4096/sizeof(union tce_entry));
>>
>>                                            ^^^^
>>TCE_PAGE_SIZE ?
> 
> 
> The PAPR explicitly says page size, it's not directly related to the
> TCE mapping size. It's not yet been explored if the firmware will deal
> properly with new base page sizes so to play it safe, I hardcoded it
> at 4K.

  Is it worth adding that as a /* comment */ above the line with the 
hardcoded 4096?


> 
> 
> -Olof
> 
> 
> 
>>_______________________________________________
>>Linuxppc64-dev mailing list
>>Linuxppc64-dev at ozlabs.org
>>https://ozlabs.org/mailman/listinfo/linuxppc64-dev
> 
> 
> _______________________________________________
> Linuxppc64-dev mailing list
> Linuxppc64-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc64-dev