[PATCH] ppc64: Updated Olof misc updates 3/3

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue Sep 20 13:47:41 EST 2005


From: Olof Johansson <olof at lixom.net>

Replace some of the hard-coded constants with PAGE_SIZE/SHIFT/ORDER where
appropriate.

Likewise, in a couple of places it doesn't make sense to base some allocations
on page size when all that's required is a constant 4K, etc.


Signed-off-by: Olof Johansson <olof at lixom.net>
Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

Index: linux-work/arch/ppc64/kernel/head.S
===================================================================
--- linux-work.orig/arch/ppc64/kernel/head.S	2005-09-20 09:54:18.000000000 +1000
+++ linux-work/arch/ppc64/kernel/head.S	2005-09-20 13:36:29.000000000 +1000
@@ -1992,7 +1992,7 @@
  */
 	.section ".bss"
 
-	.align	12
+	.align	PAGE_SHIFT
 
 	.globl	empty_zero_page
 empty_zero_page:
Index: linux-work/arch/ppc64/kernel/misc.S
===================================================================
--- linux-work.orig/arch/ppc64/kernel/misc.S	2005-09-20 09:54:18.000000000 +1000
+++ linux-work/arch/ppc64/kernel/misc.S	2005-09-20 13:36:29.000000000 +1000
@@ -329,7 +329,7 @@
 
 /* Flush the dcache */
  	ld	r7,PPC64_CACHES at toc(r2)
-	clrrdi	r3,r3,12           	    /* Page align */
+	clrrdi	r3,r3,PAGE_SHIFT           	    /* Page align */
 	lwz	r4,DCACHEL1LINESPERPAGE(r7)	/* Get # dcache lines per page */
 	lwz	r5,DCACHEL1LINESIZE(r7)		/* Get dcache line size */
 	mr	r6,r3
Index: linux-work/arch/ppc64/kernel/vmlinux.lds.S
===================================================================
--- linux-work.orig/arch/ppc64/kernel/vmlinux.lds.S	2005-09-20 09:54:18.000000000 +1000
+++ linux-work/arch/ppc64/kernel/vmlinux.lds.S	2005-09-20 13:38:14.000000000 +1000
@@ -1,3 +1,4 @@
+#include <asm/page.h>
 #include <asm-generic/vmlinux.lds.h>
 
 OUTPUT_ARCH(powerpc:common64)
@@ -17,7 +18,7 @@
 	LOCK_TEXT
 	KPROBES_TEXT
 	*(.fixup)
-	. = ALIGN(4096);
+	. = ALIGN(PAGE_SIZE);
 	_etext = .;
 	}
 
@@ -43,7 +44,7 @@
 
 
   /* will be freed after init */
-  . = ALIGN(4096);
+  . = ALIGN(PAGE_SIZE);
   __init_begin = .;
 
   .init.text : {
@@ -83,7 +84,7 @@
 
   SECURITY_INIT
 
-  . = ALIGN(4096);
+  . = ALIGN(PAGE_SIZE);
   .init.ramfs : {
 	__initramfs_start = .;
 	*(.init.ramfs)
@@ -96,18 +97,21 @@
 	__per_cpu_end = .;
 	}
 
+  . = ALIGN(PAGE_SIZE);
   . = ALIGN(16384);
   __init_end = .;
   /* freed after init ends here */
 
 
   /* Read/write sections */
+  . = ALIGN(PAGE_SIZE);
   . = ALIGN(16384);
   /* The initial task and kernel stack */
   .data.init_task : {
 	*(.data.init_task)
 	}
 
+  . = ALIGN(PAGE_SIZE);
   .data.page_aligned : {
 	*(.data.page_aligned)
 	}
@@ -129,18 +133,18 @@
 	__toc_start = .;
 	*(.got)
 	*(.toc)
-	. = ALIGN(4096);
+	. = ALIGN(PAGE_SIZE);
 	_edata = .;
 	}
 
 
-  . = ALIGN(4096);
+  . = ALIGN(PAGE_SIZE);
   .bss : {
 	__bss_start = .;
 	*(.bss)
 	__bss_stop = .;
 	}
 
-  . = ALIGN(4096);
+  . = ALIGN(PAGE_SIZE);
   _end = . ;
 }
Index: linux-work/include/asm-ppc64/elf.h
===================================================================
--- linux-work.orig/include/asm-ppc64/elf.h	2005-09-20 09:54:26.000000000 +1000
+++ linux-work/include/asm-ppc64/elf.h	2005-09-20 13:36:54.000000000 +1000
@@ -5,6 +5,7 @@
 #include <asm/ptrace.h>
 #include <asm/cputable.h>
 #include <asm/auxvec.h>
+#include <asm/page.h>
 
 /* PowerPC relocations defined by the ABIs */
 #define R_PPC_NONE		0
@@ -146,7 +147,7 @@
 #define elf_check_arch(x) ((x)->e_machine == ELF_ARCH)
 
 #define USE_ELF_CORE_DUMP
-#define ELF_EXEC_PAGESIZE	4096
+#define ELF_EXEC_PAGESIZE	PAGE_SIZE
 
 /* This is the location that an ET_DYN program is loaded if exec'ed.  Typical
    use of this is to invoke "./ld.so someprog" to test out a new version of
Index: linux-work/include/asm-ppc64/thread_info.h
===================================================================
--- linux-work.orig/include/asm-ppc64/thread_info.h	2005-08-24 13:26:46.000000000 +1000
+++ linux-work/include/asm-ppc64/thread_info.h	2005-09-20 13:36:29.000000000 +1000
@@ -54,9 +54,9 @@
 
 /* thread information allocation */
 
-#define THREAD_ORDER		2
-#define THREAD_SIZE		(PAGE_SIZE << THREAD_ORDER)
-#define THREAD_SHIFT		(PAGE_SHIFT + THREAD_ORDER)
+#define THREAD_SHIFT		14
+#define THREAD_ORDER		(THREAD_SHIFT - PAGE_SHIFT)
+#define THREAD_SIZE		(1 << THREAD_SHIFT)
 #ifdef CONFIG_DEBUG_STACK_USAGE
 #define alloc_thread_info(tsk)					\
 	({							\
Index: linux-work/include/asm-ppc64/mmu.h
===================================================================
--- linux-work.orig/include/asm-ppc64/mmu.h	2005-09-07 11:09:56.000000000 +1000
+++ linux-work/include/asm-ppc64/mmu.h	2005-09-20 13:36:29.000000000 +1000
@@ -29,7 +29,7 @@
 
 /* Location of cpu0's segment table */
 #define STAB0_PAGE	0x6
-#define STAB0_PHYS_ADDR	(STAB0_PAGE<<PAGE_SHIFT)
+#define STAB0_PHYS_ADDR	(STAB0_PAGE<<12)
 
 #ifndef __ASSEMBLY__
 extern char initial_stab[];





More information about the Linuxppc64-dev mailing list