[PATCH] Avoid use of uninitialised spinlock in EEH.

linas linas at austin.ibm.com
Thu Nov 17 10:57:44 EST 2005


On Wed, Nov 16, 2005 at 11:34:24PM +0000, David Woodhouse was heard to remark:
> On Wed, 2005-11-16 at 17:04 -0600, linas wrote:
> > You can regain most of that performance hit by reordering, 
> > so that instead of 
> > 
> > > -#define EEH_POSSIBLE_ERROR(val, type)        ((val) == (type)~0)
> > > +#define EEH_POSSIBLE_ERROR(val, type)        (eeh_subsystem_enabled && (val) == (type)~0)
> > 
> > one has
> > 
> > #define EEH_POSSIBLE_ERROR(val, type)   (((val) == (type)~0) &&
> > eeh_subsystem_enabled)
> 
> Agreed. I actually thought precisely the same thing as I glanced at the
> attached email again when I sent it. Do you want me to submit a patch
> like that?

Well, I would then sign-off-by/approve-by whatever; and then its up
to anyone else who might object.

--linas



More information about the Linuxppc64-dev mailing list