[PATCH] Avoid use of uninitialised spinlock in EEH.
David Woodhouse
dwmw2 at infradead.org
Thu Nov 17 10:34:24 EST 2005
On Wed, 2005-11-16 at 17:04 -0600, linas wrote:
> You can regain most of that performance hit by reordering,
> so that instead of
>
> > -#define EEH_POSSIBLE_ERROR(val, type) ((val) == (type)~0)
> > +#define EEH_POSSIBLE_ERROR(val, type) (eeh_subsystem_enabled && (val) == (type)~0)
>
> one has
>
> #define EEH_POSSIBLE_ERROR(val, type) (((val) == (type)~0) &&
> eeh_subsystem_enabled)
Agreed. I actually thought precisely the same thing as I glanced at the
attached email again when I sent it. Do you want me to submit a patch
like that?
--
dwmw2
More information about the Linuxppc64-dev
mailing list