[PATCH] ppc64: set/clear SMT capable bit at boot

Joel Schopp jschopp at austin.ibm.com
Tue May 31 15:42:23 EST 2005


> +	if (prop && ((size / sizeof(u32)) > 1))

If this hasn't gone out yet it might be nice to add a BUG_ON((size / 
sizeof(u32)) > 2).  I don't know of any processors that do more than 2 
way SMT, but if one comes out several years from now it would be nice to 
catch it early.  Mostly I'd like the extra BUG_ON() in order to have one 
more check against buggy firmware.

Patch looks fine with our without the extra BUG_ON()




More information about the Linuxppc64-dev mailing list