[PATCH] ppc64: set/clear SMT capable bit at boot

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Jun 2 08:25:00 EST 2005


On Tue, 2005-05-31 at 00:42 -0500, Joel Schopp wrote:
> > +	if (prop && ((size / sizeof(u32)) > 1))
> 
> If this hasn't gone out yet it might be nice to add a BUG_ON((size / 
> sizeof(u32)) > 2).  I don't know of any processors that do more than 2 
> way SMT, but if one comes out several years from now it would be nice to 
> catch it early.  Mostly I'd like the extra BUG_ON() in order to have one 
> more check against buggy firmware.
> 
> Patch looks fine with our without the extra BUG_ON()

Rather than BUG_ON, just keep SMT feature cleared and dump something in
dmesg, let's me kind to users, we are very early during boot, it would
be a bit difficult to track down that BUG (no console yet).

Ben.





More information about the Linuxppc64-dev mailing list