[PATCH 20/21] ppc64/traps: replace schedule_timeout() with ssleep()

Nishanth Aravamudan nacc at us.ibm.com
Tue Jan 18 11:21:30 EST 2005


Hi,

Please consider applying. 

Description:  Use ssleep() instead of schedule_timeout() to guarantee the task
delays as expected. The current code is not incorrect, but using ssleep()
encourages specifying delays in real time-units and consistency across the
kernel.

Signed-off-by: Nishanth Aravamudan <nacc at us.ibm.com>

--- 2.6.11-rc1-kj-v/arch/ppc64/kernel/traps.c	2005-01-15 16:55:41.000000000 -0800
+++ 2.6.11-rc1-kj/arch/ppc64/kernel/traps.c	2005-01-15 17:30:39.000000000 -0800
@@ -29,6 +29,7 @@
 #include <linux/interrupt.h>
 #include <linux/init.h>
 #include <linux/module.h>
+#include <linux/delay.h>
 #include <asm/kdebug.h>
 
 #include <asm/pgtable.h>
@@ -137,8 +138,7 @@ int die(const char *str, struct pt_regs 
 
 	if (panic_on_oops) {
 		printk(KERN_EMERG "Fatal exception: panic in 5 seconds\n");
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout(5 * HZ);
+		ssleep(5);
 		panic("Fatal exception");
 	}
 	do_exit(SIGSEGV);



More information about the Linuxppc64-dev mailing list