[PATCH 19/21] ppc64/smp: replace schedule_timeout() with msleep()

Nishanth Aravamudan nacc at us.ibm.com
Tue Jan 18 11:20:13 EST 2005


Hi,

Please consider applying. 

Description: Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected. The current code is not incorrect; however using msleep()
encourages using real time-unit sleeps and keeps the kernel consistent.

Signed-off-by: Nishanth Aravamudan <nacc at us.ibm.com>

--- 2.6.11-rc1-kj-v/arch/ppc64/kernel/smp.c	2005-01-15 16:55:41.000000000 -0800
+++ 2.6.11-rc1-kj/arch/ppc64/kernel/smp.c	2005-01-15 17:30:16.000000000 -0800
@@ -459,8 +459,7 @@ int __devinit __cpu_up(unsigned int cpu)
 		 * hotplug case.  Wait five seconds.
 		 */
 		for (c = 25; c && !cpu_callin_map[cpu]; c--) {
-			set_current_state(TASK_UNINTERRUPTIBLE);
-			schedule_timeout(HZ/5);
+			msleep(200);
 		}
 #endif
 



More information about the Linuxppc64-dev mailing list