[RFC] don't create cpu/online sysfs file

Rusty Russell rusty at rustcorp.com.au
Mon Jun 7 09:08:18 EST 2004

On Sat, 2004-06-05 at 08:32, Dave Hansen wrote:
> On Fri, 2004-06-04 at 15:06, Joel Schopp wrote:
> > I might change cpu_is_hotpluggable to __cpu_is_hotpluggable to help
> > indicate it is a platform specific function.
> Yeah, that naming is a lot more consistent with the other functions in
> the arch-specific cpu hotplug code.  New version attached.

The purpose of __ is to indicate a low-level function which requires
special knowledge to call (usually a lock).  The cpu hotplug code is a
little odd, but way back when, it had cpu_disable() and cpu_die(), so
the arch-specific parts which actually did the work were called
__cpu_disable() and __cpu_die().  The names stuck.

There's nothing special required to call cpu_is_hotpluggable(), so it's
wrong to prepend __.

Sorry for the inconsistency,
Anyone who quotes me in their signature is an idiot -- Rusty Russell

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list