[PATCH] 2.6 ppc64 RTAS: use dynamic buffer size

[Linas Vepstas]

On Thu, Jul 22, 2004 at 03:24:53PM -0400, Paul Mackerras was heard to remark:
>
> > Firmware expects error log sizes to be of a very specific size,
> > but different versions of firmware appearently expect different
> > sizes; using the wrong size results in a painful, hard-to-debug
> > crash in firmware. Benh provided a patch for this some months ago,
> > but appreantly missed this code path. This patch sets up the log
> > buffer size dynamically; it also fixes a bug with the return code
> > not being handled correctly.
>
> Just small nit, but this hunk looks pointless:
>
> > @@ -105,6 +111,7 @@
> >  	err_args = rtas.args;
> >  	rtas.args = save_args;
> >
> > +	err_args.rets = (rtas_arg_t *)&(err_args.args[2]);
> >  	return err_args.rets[0];
> >  }

heh.
I wondered if anyone would notice..
Yes, put this line back to where it used to be.

Silly me, for a moment there, I was thinking that
firmware was looking at this value and so I was desperately
trying to make sure it was right; I need'nt have worried.
I realized this right after I hit "send" on email ...

> The rest of it looks fine. If you agree that this hunk can go, I'll
> send the rest of it upstream.

Yep, Just make sure that 'rets' is set somewhere in there,
anywhere (e.g. put this line back to how it used to be).

--linas

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/