[PATCH] 2.6 ppc64 RTAS: use dynamic buffer size
Paul Mackerras
paulus at samba.org
Fri Jul 23 05:24:53 EST 2004
Linas,
> Firmware expects error log sizes to be of a very specific size,
> but different versions of firmware appearently expect different
> sizes; using the wrong size results in a painful, hard-to-debug crash
> in firmware. Benh provided a patch for this some months ago, but
> appreantly missed this code path. This patch sets up the log buffer
> size dynamically; it also fixes a bug with the return code not being
> handled correctly.
Just small nit, but this hunk looks pointless:
> @@ -105,6 +111,7 @@
> err_args = rtas.args;
> rtas.args = save_args;
>
> + err_args.rets = (rtas_arg_t *)&(err_args.args[2]);
> return err_args.rets[0];
> }
>
The rest of it looks fine. If you agree that this hunk can go, I'll
send the rest of it upstream.
Paul.
** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/
More information about the Linuxppc64-dev
mailing list