[PATCH] ppc64: pSeries shared processor fixes

Nathan Lynch nathanl at austin.ibm.com
Fri Dec 10 05:03:06 EST 2004


On Thu, 2004-12-09 at 11:25 -0600, Joel Schopp wrote:
> > Hi,
> > 
> > It turns out there are more issues with our VPA code:
> > 
> > 1. vpa_init doesnt report errors when it fails. This was masking a bug
> > where the VPA spanned 2 pages and phyp failed to register it.
> > 2. We call idle_setup before we initialise the boot cpus vpa. This means
> > we never select the shared processor idle loop.
> > 3. We dont call vpa_init on UP kernels.
> > 
> > I think this should go in ASAP, can people give it a once over?
> 
> Wow.  We really weren't ever using shared idle.

IIRC it was working around the 2.6.5 or 2.6.6 timeframe.  I think it's
likely that some of the code reorganizations and cleanups that have gone
in since then introduced the bug.

Nathan




More information about the Linuxppc64-dev mailing list