[PPC64] Patch to correct alignment for lppaca in paca_struct

David Gibson david at gibson.dropbear.id.au
Tue Dec 7 11:27:06 EST 2004


On Mon, Dec 06, 2004 at 10:28:06AM -0800, Dave Hansen wrote:
> On Mon, 2004-12-06 at 09:16, will schmidt wrote:
> > -	struct ItLpPaca lppaca __attribute__((aligned(0x80)));
> > +	struct ItLpPaca lppaca __attribute__((aligned(0x400)));
> 
> Do you have guarantees about how large the lppaca can get?  If it's
> larger than 0x400 bytes, you can still cross a page boundary, right? 
> Maybe you should just align it to PAGE_SIZE and be done with it.  

The lppaca is part of the firmware ABI, so it can't just go randomly
changing or growing.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist.  NOT _the_ _other_ _way_
				| _around_!
http://www.ozlabs.org/people/dgibson



More information about the Linuxppc64-dev mailing list