cpumask move patch - RFC

R Sharada sharada at in.ibm.com
Fri Aug 6 14:26:27 EST 2004

Nathan, Paul,
	Thanks for your valuable feedback. I noted your comments and shall work
on a revised patch and put it up for review soon.

Thanks and Regards,

On Fri, Aug 06, 2004 at 11:54:05AM +1000, Paul Mackerras wrote:
> Nathan Lynch writes:
> > This is incorrect -- get_property does not return the size of the
> > property; it stores the size in the third argument.  The return value of
> > get_property is a pointer to the kernel's copy of the property itself.
> Good point.
> I notice also that we need to check for statusp != NULL in this code:
> +		statusp = (char *)get_property(np, "status", NULL);
> +		if (strcmp(statusp, "okay") != 0)
> +			continue;
> > While I agree in theory with removing all the cpumask initializations
> > from prom_hold_cpus, I don't think simply transplanting the mess is the
> > way to do it.  Wouldn't it be nice to have one loop which works on pmac
> > and pSeries, SMP and UP, without all those #ifdef's?
> It would be nice, if it turns out to be possible. :)  It's not clear
> that there is enough consistency between the device tree
> representations on the different platforms to be able to achieve that.
> I think what Sharada has done is a useful first step.  At least now we
> can get rid of a bunch of RELOCs.  Sharada, could you do a revised
> patch?
> Thanks,
> Paul.

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list