[PATCH][2.4] VIO infrastructure update - review request

Santiago Leon santil at us.ibm.com
Sat Nov 1 03:42:46 EST 2003

Hey John.. thanks for the comments...

> - vio_register_device():  Might it be more clear to accept a struct
>   device_node * here rather than a void *?  Is this done for
>   portability?  Currently you have to cast the device node * to void *
>   when calling, and then cast the void * back to device node once
>   inside the function.

Yes, the idea of using a void * was to make it more portable. Now that I
think about it, it doesn't make too much sense because if someone else
wants to use the interface, they can write their own vio_dev struct.

I will apply the suggestions,

Santiago A. Leon
Power Linux Development
IBM Linux Technology Center
Off: (919) 254-6048  T/L: 444-6048  Fax: (919) 543-7378

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list