[PATCH 1/2] Added support for PRTLVT based boards (MPC5121)

David Gibson david at gibson.dropbear.id.au
Fri Jun 13 14:19:43 EST 2008


On Thu, Jun 12, 2008 at 08:10:47AM -0600, Grant Likely wrote:
[snip]
> > +               i2ccontrol at 1760 {
> > +                       compatible = "fsl,mpc5121-i2c-ctrl";
> > +                       reg = <0x1760 0x8>;
> > +               };
> > +
> > +               diu at 2100 {
> 
> (nitpick) There is a recommended practice that says node names should
> be generic as much as possible, so I think this should probably be
> video at 2100.  The compatible value is fine.

If this is a video display device, the recommended generic name is
"display at XX", not "video at XX".

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson


More information about the Linuxppc-embedded mailing list