[PATCH 1/2] Added support for PRTLVT based boards (MPC5121)

[Scott Wood]

On Thu, Jun 12, 2008 at 08:54:27AM +0200, David Jander wrote:
> On Wednesday 11 June 2008 19:58:32 Scott Wood wrote:
> > > +		//axe at 2000 {
> > > +		//	compatible = "mpc512x-axe";
> > > +		//	reg = <2000 100>;
> > > +		//	interrupts = <2a 8>;
> > > +		//	interrupt-parent = < &ipic >;
> > > +		//};
> >
> > Why is this here, but commented out?
> 
> Hmm, I know we are going to use it, but there are no drivers still...
> I'll leave it out, and add it again later when axe-support has arrived.

Just uncomment it -- there's no harm in a device node for which Linux has
no driver, and it avoids problems with old device trees being used once a
driver is added.

Compatible should have "fsl," prepended, though, and ideally a concrete
chip should be represented rather than "512x".

> > > +		dma2 at 14000 {
> > > +			compatible = "fsl,mpc5121-dma2";
> >
> > Is this DMA controller compatible with drivers/dma/fsldma.c?  If so,
> > follow the established binding.
> 
> No, it's not compatible with any other dma controller AFAIK. It special for 
> this chip. John Rigby is writing the driver for it right now.

OK.

> Btw, is it ok I just re-submit the fixed patches (with cc to linuxppc-dev)?

Yes.

-Scott