[PATCH] [UPDATED] tsec: Allow Ten Bit Interface to be configurable

Andy Fleming afleming at freescale.com
Wed Aug 15 02:04:04 EST 2007


On Aug 13, 2007, at 22:29, Joe Hamman wrote:

>>
>>
>> On Aug 13, 2007, at 5:37 PM, Joe Hamman wrote:
>>
>>> Allow the address of the Ten Bit Interface (TBI) to be changed in  
>>> the
>>> event of a conflict with another device.
>>>
>>> Signed-off by: Joe Hamman <joe.hamman at embeddedspecialties.com>
>>> ---
>>>
>>> Please ignore the last patch - I missed a cut & paste error on the
>>> range
>>> that my testing didn't catch.
>>
>> I think we'd rather this came from the device tree.
>>
> Duh, that makes sense ;-)
>
> Has there been any discussion yet?  Maybe something like this:
>
> 		mdio at 24520 {
>

...

> 			phy3: ethernet-phy at 3 {
> 				interrupt-parent = <&mpic>;
> 				interrupts = <a 1>;
> 				reg = <3>;
> 				device_type = "ethernet-phy";
> 			};
> 			tbi:  ethernet-tbi at 1f {
> 				reg = <1f>;
> 				device_type = "ethernet-tbi";
> 			};

It's actually a per-tsec property.  There's not one tbi, there's one  
per TSEC.  The one on TSEC 0 is special in that it can interfere with  
PHYs on the MDIO bus.

So I would suggest making it a property of the ethernet node:

ethernet at 24000 {
...
tbipa = <1f>;
...
}

etc

Andy




More information about the Linuxppc-embedded mailing list