[PATCH] 8xx PCMCIA: support for MPC885ADS and MPC866ADS

Dan Malek dan at embeddededge.com
Thu Nov 24 07:22:40 EST 2005


On Nov 23, 2005, at 7:53 AM, Marcelo Tosatti wrote:

> Shouldnt you handle ioremap() failure? Most 85xx code written
> by Kumar also does not.

And do what if it fails?  Chances are you don't have any
way to report an error message or panic at this point.  In
fact, there are a few silly tests like this where the
failure tries to panic or print some message that will never
be seen.  Fortunately, the code will never fail and we will
never take such code paths.


	-- Dan




More information about the Linuxppc-embedded mailing list