[PATCH] 8xx PCMCIA: support for MPC885ADS and MPC866ADS

Kumar Gala galak at kernel.crashing.org
Thu Nov 24 05:42:39 EST 2005


On Nov 23, 2005, at 6:53 AM, Marcelo Tosatti wrote:

> Hi Vitaly,
>
> On Fri, Nov 18, 2005 at 07:42:51PM +0300, Vitaly Bordug wrote:
>> This adds adds PCMCIA supported for  both MPC885ADS and MPC866ADS.
>>
>> This is established not together with FADS, because 885 does not have
>> io_block_mapping() for BCSR area.
>> Also, some cleanups done both for 885ADS and MBX.
>>
>> Signed-off-by: Vitaly Bordug <vbordug at ru.mvista.com>
>
> <snip>
>
>> +	bcsr_io = ioremap(BCSR1, sizeof(unsigned long));
>
> Shouldnt you handle ioremap() failure? Most 85xx code written
> by Kumar also does not.

Ok, I'll take a hint to go audit my code for ioremap() returns :)

- kumar




More information about the Linuxppc-embedded mailing list