8260 CPM DP ram free function

Rune Torgersen runet at innovsys.com
Sat May 22 07:52:06 EST 2004


> Will you please get rid of those #ifdefs?  If the code works,
> just use it, if not, don't ask for a patch to be applied.
> There is no reason for this.

Ok

> The "host" functions should simply be removed and drivers
> should use kmalloc()/kfree(), manage their own alignment
> restrictions, since the 82xx is cache coherent.

Not sure how easy that would be. The host_alloc and dp_alloc gets called
at few times _before_ kmem_cache_init() is called, so a kmalloc call
panic()s the kernel.
I know, because I tried to use kmalloc for handling the linked lists for
the dp_alloc/free functions.

It would make allocating buffers in drivers easier.

> Let's clean this up and do it right if we are going to do it at all.
Cleaning up is always good.

Any more suggestions before I remove the #ifdefs and resubmit?

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/





More information about the Linuxppc-embedded mailing list