consistent_alloc() revisited

[Ralph Blach]

Dan and Matt

I agree with you 100%

Chip


---------------------- Forwarded by Ralph Blach/Raleigh/IBM on 07/16/2002
12:13 PM ---------------------------

Matt Porter <porter at cox.net>@lists.linuxppc.org on 07/16/2002 11:27:26 AM

Sent by:    owner-linuxppc-embedded at lists.linuxppc.org


To:    Dan Malek <dan at embeddededge.com>
cc:    David Gibson <david at gibson.dropbear.id.au>,
       linuxppc-embedded at lists.linuxppc.org
Subject:    Re: consistent_alloc() revisited




On Tue, Jul 16, 2002 at 10:09:03AM -0400, Dan Malek wrote:
>
> David Gibson wrote:
> > - if (in_interrupt())
> > -       BUG();
> > + BUG_ON(in_interrupt());
>
> We should be able to call these functions from interrupt, let's push
> the remainder of the changes though get_free_pages() to make this happen.

Yes, not just "should", but "must".  They must be callable from an
interrupt since many generic drivers follow the rules as they have
been laid down and allocate from an interrupt context.

Regards,
--
Matt Porter
porter at cox.net
This is Linux Country. On a quiet night, you can hear Windows reboot.


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/