[PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Segher Boessenkool]

On Wed, Mar 18, 2026 at 12:54:30PM +0100, Krzysztof Kozlowski wrote:
> On 18/03/2026 12:51, Segher Boessenkool wrote:
> > On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote:
> >> Return value of ps3_start_probe_thread() is not used, so code can be
> >> simplified to fix W=1 clang warnings:
> >>
> >>   arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
> > 
> > And this is exactly why -Werror is harmful.  A boring harmless warning
> > turned into a build break :-(
> 
> -Werror does not matter here. We do not want warnings either, assuming
> of course they are correct.
> 
> So if this warning is correct, then patch should be applied and WERROR
> is irrelevant.

The build is broken.  -Werror is positively harmful.

Yes, you want the warnings fixed, but maybe something else has priority
right now?


Segher