powermac: Call of_node_put(bk_node) only once in pmac_has_backlight_type()

Markus Elfring Markus.Elfring at web.de
Mon Oct 7 18:15:51 AEDT 2024


> First of all, the change is wrong.  We can't dereference "prop" after calling
> of_node_put().
…
> The of_get_property() function doesn't do a get as in get/put, it just finds
> the property and returns it.  It doesn't bump the reference count.  It's a
> confusing name in that way.  The The of_node_put() pairs with
> of_find_node_by_name().
Thanks for your information.

* Do you see opportunities for improving the software documentation accordingly?

* How much can source code analysis tools influence development efforts?


Regards,
Markus


More information about the Linuxppc-dev mailing list