[PATCH] powermac: Call of_node_put(bk_node) only once in pmac_has_backlight_type()

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Thu Oct 3 16:53:31 AEST 2024


On 03/10/2024 07:56, Dan Carpenter wrote:
> First of all, the change is wrong.  We can't dereference "prop" after calling
> of_node_put().  You have to be a bit extra careful reviewing Markus's patches
> because a lot of the rest of us have blocked these messages so you're on your
> own in that way.

Yep, I plonked him some time ago and everything is in spam.

The code looks just incorrect and I think Markus did not understand it
before transforming.

Best regards,
Krzysztof



More information about the Linuxppc-dev mailing list