[PATCH 0/3] PCI: dwc: Improve code readability
Geert Uytterhoeven
geert at linux-m68k.org
Mon Nov 13 22:07:08 AEDT 2023
Hi Krzysztof,
On Mon, Nov 13, 2023 at 11:09 AM Krzysztof Wilczyński <kw at linux.com> wrote:
> > This patch series is based on the latest pci.git / next branch.
> [...]
>
> Thank you for following up to tidy things up! Much appreciated.
>
> Now, while you are looking at things, can you also take care about the following:
>
> drivers/pci/controller/dwc/pcie-rcar-gen4.c:439:15: warning: cast to smaller integer type 'enum dw_pcie_device_mode' from 'const void *' [-Wvoid-pointer-to-enum-cast]
>
> This requires adding structs for each data member of the of_device_id type.
That sounds like overkill to me.
An intermediate cast to uintptr_t should fix the issue as well.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
More information about the Linuxppc-dev
mailing list