[PATCH 0/3] PCI: dwc: Improve code readability
Krzysztof Wilczyński
kw at linux.com
Mon Nov 13 21:09:14 AEDT 2023
Hi Yoshihiro!
> This patch series is based on the latest pci.git / next branch.
[...]
Thank you for following up to tidy things up! Much appreciated.
Now, while you are looking at things, can you also take care about the following:
drivers/pci/controller/dwc/pcie-rcar-gen4.c:439:15: warning: cast to smaller integer type 'enum dw_pcie_device_mode' from 'const void *' [-Wvoid-pointer-to-enum-cast]
This requires adding structs for each data member of the of_device_id type.
Some examples from other drivers:
- https://elixir.bootlin.com/linux/v6.6.1/source/drivers/pci/controller/dwc/pcie-tegra194.c#L2440
- https://elixir.bootlin.com/linux/v6.6.1/source/drivers/pci/controller/dwc/pci-keystone.c#L1074
Thank you! :)
Krzysztof
More information about the Linuxppc-dev
mailing list