[PATCH 12/22] powerpc/cpu: Mark start_secondary_resume() __noreturn
Josh Poimboeuf
jpoimboe at kernel.org
Tue Feb 7 09:22:02 AEDT 2023
On Mon, Feb 06, 2023 at 10:10:22PM +1100, Michael Ellerman wrote:
> Josh Poimboeuf <jpoimboe at kernel.org> writes:
> > start_secondary_resume() doesn't return. Annotate it as such. By
> > extension this also makes arch_cpu_idle_dead() noreturn.
>
> Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ?
>
> Seems like it would be good documentation, even if it's not required
> once the generic prototype is __noreturn.
Yeah, agreed. Maybe I'll do that (for all the implementations) with
patch 22.
> But not a show-stopper.
>
> Acked-by: Michael Ellerman <mpe at ellerman.id.au> (powerpc)
Thanks!
--
Josh
More information about the Linuxppc-dev
mailing list