[PATCH 12/22] powerpc/cpu: Mark start_secondary_resume() __noreturn
Michael Ellerman
mpe at ellerman.id.au
Mon Feb 6 22:10:22 AEDT 2023
Josh Poimboeuf <jpoimboe at kernel.org> writes:
> start_secondary_resume() doesn't return. Annotate it as such. By
> extension this also makes arch_cpu_idle_dead() noreturn.
Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ?
Seems like it would be good documentation, even if it's not required
once the generic prototype is __noreturn.
But not a show-stopper.
Acked-by: Michael Ellerman <mpe at ellerman.id.au> (powerpc)
cheers
> diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h
> index f63505d74932..cfd42ca8765c 100644
> --- a/arch/powerpc/include/asm/smp.h
> +++ b/arch/powerpc/include/asm/smp.h
> @@ -66,7 +66,7 @@ void start_secondary(void *unused);
> extern int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us);
> extern int smp_send_safe_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us);
> extern void smp_send_debugger_break(void);
> -extern void start_secondary_resume(void);
> +extern void __noreturn start_secondary_resume(void);
> extern void smp_generic_give_timebase(void);
> extern void smp_generic_take_timebase(void);
>
> --
> 2.39.0
More information about the Linuxppc-dev
mailing list