[PATCH v2 01/14] powerpc: Adopt SYSCALL_DEFINE for arch-specific syscall handlers

[Christophe Leroy]

Le 08/08/2022 à 08:04, Rohan McLure a écrit :
> Thanks for reviewing my patches.
> 
>> I think this patch should be split in two patches. One where you just
>> change to using SYSCALL_DEFINE and COMPAT_SYSCALL_DEFINE, and a second
>> patch for everything else.
>>
>> The first patch could then be linked to
>> https://github.com/linuxppc/issues/issues/146
>>
>> Or in the reverse order if it makes more sense maybe.
> 
> My reasoning for completing all of these changes in a single patch is for
> retaining bisectability. Adopting SYSCALL_DEFINE and COMPAT_SYSCALL_DEFINE
> prepends {sys_, compat_sys_} to the symbol names, and so this must be
> reflected immediately in the symbol tables.

Well, of course we need the patch build, so SYSCALL_DEFINE and 
COMPAT_SYSCALL_DEFINE have to go with the name changes, that's obvious.

My comment was more related to changes like the renaming of 
ppc64_personality() to do_ppc64_personality() and the creation of 
sys_ppc64_personality() and compat_....
That could be a patch by itself.

Also patch 4 could go up front in order to avoid renaming a function you 
are removing in a follow-up patch.

So as a summary, do all preparation up front of patch 1, in order to 
keep it as minimal.

> 
>> Is that 'asmlinkage' still needed ? Not all syscalls have it seems, and
>> as far as I can see that macro voids for powerpc.
> 
> Sorry, you commented on this in the previous revision, and I should have
> acted on it then. I in fact touch all but one usages of ‘asmlinkage’ in arch/powerpc, and so am in a good position to get rid of all of them. I’ll
> do that in next revision.
>