[PATCH v2 01/14] powerpc: Adopt SYSCALL_DEFINE for arch-specific syscall handlers

Rohan McLure rmclure at linux.ibm.com
Mon Aug 8 16:04:53 AEST 2022


Thanks for reviewing my patches.

> I think this patch should be split in two patches. One where you just 
> change to using SYSCALL_DEFINE and COMPAT_SYSCALL_DEFINE, and a second 
> patch for everything else.
> 
> The first patch could then be linked to 
> https://github.com/linuxppc/issues/issues/146
> 
> Or in the reverse order if it makes more sense maybe.

My reasoning for completing all of these changes in a single patch is for
retaining bisectability. Adopting SYSCALL_DEFINE and COMPAT_SYSCALL_DEFINE
prepends {sys_, compat_sys_} to the symbol names, and so this must be
reflected immediately in the symbol tables.

> Is that 'asmlinkage' still needed ? Not all syscalls have it seems, and 
> as far as I can see that macro voids for powerpc.

Sorry, you commented on this in the previous revision, and I should have
acted on it then. I in fact touch all but one usages of ‘asmlinkage’ in arch/powerpc, and so am in a good position to get rid of all of them. I’ll
do that in next revision.



More information about the Linuxppc-dev mailing list