[PATCH v3 3/3] powerpc/64s: feature: Work around inline asm issues
Bill Wendling
morbo at google.com
Tue Nov 24 07:01:01 AEDT 2020
On Mon, Nov 23, 2020 at 11:58 AM Segher Boessenkool
<segher at kernel.crashing.org> wrote:
>
> > On Sun, Nov 22, 2020 at 10:36 PM Segher Boessenkool
> > <segher at kernel.crashing.org> wrote:
> > > "true" (as a result of a comparison) in as is -1, not 1.
>
> On Mon, Nov 23, 2020 at 11:43:11AM -0800, Bill Wendling wrote:
> > What Segher said. :-) Also, if you reverse the comparison, you'll get
> > a build error.
>
> But that means your patch is the wrong way around?
>
> - .ifgt (label##4b- label##3b)-(label##2b- label##1b); \
> - .error "Feature section else case larger than body"; \
> - .endif; \
> + .org . - ((label##4b-label##3b) > (label##2b-label##1b)); \
>
> It should be a + in that last line, not a -.
I said so in a follow up email.
> Was this tested?
>
Please don't be insulting. Anyone can make an error.
-bw
More information about the Linuxppc-dev
mailing list