[PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

Geert Uytterhoeven geert at linux-m68k.org
Sun May 31 18:38:04 AEST 2020


Hi Finn,

On Sun, May 31, 2020 at 1:20 AM Finn Thain <fthain at telegraphics.com.au> wrote:
> The adb_driver.autopoll method is needed during ADB bus scan and device
> address assignment. Implement this method so that the IOP's list of
> device addresses can be updated. When the list is empty, disable SRQ
> autopolling.
>
> Cc: Joshua Thompson <funaho at jurai.org>
> Cc: Geert Uytterhoeven <geert at linux-m68k.org>
> Tested-by: Stan Johnson <userm57 at yahoo.com>
> Signed-off-by: Finn Thain <fthain at telegraphics.com.au>

Thanks for your patch!

Acked-by: Geert Uytterhoeven <geert at linux-m68k.org>

>  arch/m68k/include/asm/adb_iop.h |  1 +
>  drivers/macintosh/adb-iop.c     | 32 ++++++++++++++++++++++++++------

As this header file is used by a single source file only, perhaps it should
just be absorbed by the latter?
Then you no longer need my Acked-by for future changes ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


More information about the Linuxppc-dev mailing list