[PATCH v2 3/4] powerpc: Fix instruction dumping to use address value correctly
Aneesh Kumar K.V
aneesh.kumar at linux.ibm.com
Sun May 24 19:38:21 AEST 2020
Use ___va() to convert the real address that will skip the input
validation. We can get interrupts with IR=0 and with NIP value > PAGE_OFFSET.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.ibm.com>
---
arch/powerpc/include/asm/processor.h | 9 +++++++++
arch/powerpc/kernel/process.c | 7 ++-----
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/processor.h b/arch/powerpc/include/asm/processor.h
index 4e53df163b92..8bf7921dceca 100644
--- a/arch/powerpc/include/asm/processor.h
+++ b/arch/powerpc/include/asm/processor.h
@@ -441,6 +441,15 @@ extern void cvt_fd(float *from, double *to);
extern void cvt_df(double *from, float *to);
extern void _nmask_and_or_msr(unsigned long nmask, unsigned long or_val);
+static inline unsigned long fixup_real_addr(struct pt_regs *regs,
+ unsigned long addr)
+{
+ if (!(regs->msr & MSR_IR))
+ return (unsigned long)___va(addr);
+
+ return addr;
+}
+
#ifdef CONFIG_PPC64
/*
* We handle most unaligned accesses in hardware. On the other hand
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 93bf4a766707..de07b796222d 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -1262,12 +1262,9 @@ static void show_instructions(struct pt_regs *regs)
/* If executing with the IMMU off, adjust pc rather
* than print XXXXXXXX.
*/
- if (!(regs->msr & MSR_IR)) {
- pc = (unsigned long)phys_to_virt(pc);
- nip = (unsigned long)phys_to_virt(regs->nip);
- }
+ pc = fixup_real_addr(regs, pc);
+ nip = fixup_real_addr(regs, nip);
#endif
-
for (i = 0; i < NR_INSN_TO_PRINT; i++) {
int instr;
--
2.26.2
More information about the Linuxppc-dev
mailing list