[PATCH v4 11/16] powerpc/64s: machine check interrupt update NMI accounting

kbuild test robot lkp at intel.com
Sat May 9 13:13:13 AEST 2020


Hi Nicholas,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on tip/perf/core v5.7-rc4 next-20200508]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-machine-check-and-system-reset-fixes/20200509-030554
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-randconfig-r002-20200509 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/kernel.h:15,
                    from include/asm-generic/bug.h:19,
                    from arch/powerpc/include/asm/bug.h:109,
                    from include/linux/bug.h:5,
                    from arch/powerpc/include/asm/mmu.h:130,
                    from arch/powerpc/include/asm/paca.h:18,
                    from arch/powerpc/include/asm/current.h:13,
                    from include/linux/sched.h:12,
                    from arch/powerpc/kernel/process.c:14:
   arch/powerpc/kernel/process.c: In function 'show_regs':
>> arch/powerpc/kernel/process.c:1425:74: error: 'struct paca_struct' has no member named 'in_nmi'
    1425 |  pr_cont("IRQMASK: %lx IN_NMI:%d IN_MCE:%d", regs->softe, (int)get_paca()->in_nmi, (int)get_paca()->in_mce);
         |                                                                          ^~
   include/linux/printk.h:312:26: note: in definition of macro 'pr_cont'
     312 |  printk(KERN_CONT fmt, ##__VA_ARGS__)
         |                          ^~~~~~~~~~~
>> arch/powerpc/kernel/process.c:1425:99: error: 'struct paca_struct' has no member named 'in_mce'
    1425 |  pr_cont("IRQMASK: %lx IN_NMI:%d IN_MCE:%d", regs->softe, (int)get_paca()->in_nmi, (int)get_paca()->in_mce);
         |                                                                                                   ^~
   include/linux/printk.h:312:26: note: in definition of macro 'pr_cont'
     312 |  printk(KERN_CONT fmt, ##__VA_ARGS__)
         |                          ^~~~~~~~~~~

vim +1425 arch/powerpc/kernel/process.c

  1401	
  1402	void show_regs(struct pt_regs * regs)
  1403	{
  1404		int i, trap;
  1405	
  1406		show_regs_print_info(KERN_DEFAULT);
  1407	
  1408		printk("NIP:  "REG" LR: "REG" CTR: "REG"\n",
  1409		       regs->nip, regs->link, regs->ctr);
  1410		printk("REGS: %px TRAP: %04lx   %s  (%s)\n",
  1411		       regs, regs->trap, print_tainted(), init_utsname()->release);
  1412		printk("MSR:  "REG" ", regs->msr);
  1413		print_msr_bits(regs->msr);
  1414		pr_cont("  CR: %08lx  XER: %08lx\n", regs->ccr, regs->xer);
  1415		trap = TRAP(regs);
  1416		if ((TRAP(regs) != 0xc00) && cpu_has_feature(CPU_FTR_CFAR))
  1417			pr_cont("CFAR: "REG" ", regs->orig_gpr3);
  1418		if (trap == 0x200 || trap == 0x300 || trap == 0x600)
  1419	#if defined(CONFIG_4xx) || defined(CONFIG_BOOKE)
  1420			pr_cont("DEAR: "REG" ESR: "REG" ", regs->dar, regs->dsisr);
  1421	#else
  1422			pr_cont("DAR: "REG" DSISR: %08lx ", regs->dar, regs->dsisr);
  1423	#endif
  1424	#ifdef CONFIG_PPC64
> 1425		pr_cont("IRQMASK: %lx IN_NMI:%d IN_MCE:%d", regs->softe, (int)get_paca()->in_nmi, (int)get_paca()->in_mce);
  1426	#endif
  1427	#ifdef CONFIG_PPC_TRANSACTIONAL_MEM
  1428		if (MSR_TM_ACTIVE(regs->msr))
  1429			pr_cont("\nPACATMSCRATCH: %016llx ", get_paca()->tm_scratch);
  1430	#endif
  1431	
  1432		for (i = 0;  i < 32;  i++) {
  1433			if ((i % REGS_PER_LINE) == 0)
  1434				pr_cont("\nGPR%02d: ", i);
  1435			pr_cont(REG " ", regs->gpr[i]);
  1436			if (i == LAST_VOLATILE && !FULL_REGS(regs))
  1437				break;
  1438		}
  1439		pr_cont("\n");
  1440	#ifdef CONFIG_KALLSYMS
  1441		/*
  1442		 * Lookup NIP late so we have the best change of getting the
  1443		 * above info out without failing
  1444		 */
  1445		printk("NIP ["REG"] %pS\n", regs->nip, (void *)regs->nip);
  1446		printk("LR ["REG"] %pS\n", regs->link, (void *)regs->link);
  1447	#endif
  1448		show_stack(current, (unsigned long *) regs->gpr[1]);
  1449		if (!user_mode(regs))
  1450			show_instructions(regs);
  1451	}
  1452	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 26096 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20200509/54f525df/attachment-0001.gz>


More information about the Linuxppc-dev mailing list