[PATCH devicetree 3/4] powerpc: dts: t1040rdb: put SGMII PHY under &mdio0 label

Madalin Bucur (OSS) madalin.bucur at oss.nxp.com
Thu Jul 23 15:40:48 AEST 2020


> -----Original Message-----
> From: Vladimir Oltean <olteanv at gmail.com>
> Sent: Wednesday, July 22, 2020 8:24 PM
> To: robh+dt at kernel.org; shawnguo at kernel.org; mpe at ellerman.id.au;
> devicetree at vger.kernel.org
> Cc: benh at kernel.crashing.org; paulus at samba.org; linuxppc-
> dev at lists.ozlabs.org; linux-kernel at vger.kernel.org;
> netdev at vger.kernel.org; Madalin Bucur (OSS) <madalin.bucur at oss.nxp.com>;
> Radu-andrei Bulie <radu-andrei.bulie at nxp.com>; fido_max at inbox.ru
> Subject: [PATCH devicetree 3/4] powerpc: dts: t1040rdb: put SGMII PHY
> under &mdio0 label
> 
> We're going to add 8 more PHYs in a future patch. It is easier to follow
> the hardware description if we don't need to fish for the path of the
> MDIO controllers inside the SoC and just use the labels.
> 

Please align to the existing structure, it may be easier to add something
without paying attention to that but it's better to keep things organized.
This structure is used across all the device trees of the platforms using
DPAA, let's not start diverging now.

> Signed-off-by: Vladimir Oltean <olteanv at gmail.com>
> ---
>  arch/powerpc/boot/dts/fsl/t1040rdb.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> b/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> index 65ff34c49025..40d7126dbe90 100644
> --- a/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> +++ b/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> @@ -59,12 +59,6 @@ ethernet at e4000 {
>  				phy-handle = <&phy_sgmii_2>;
>  				phy-connection-type = "sgmii";
>  			};
> -
> -			mdio at fc000 {
> -				phy_sgmii_2: ethernet-phy at 3 {
> -					reg = <0x03>;
> -				};
> -			};
>  		};
>  	};
> 
> @@ -76,3 +70,9 @@ cpld at 3,0 {
>  };
> 
>  #include "t1040si-post.dtsi"
> +
> +&mdio0 {
> +	phy_sgmii_2: ethernet-phy at 3 {
> +		reg = <0x3>;
> +	};
> +};
> --
> 2.25.1



More information about the Linuxppc-dev mailing list