Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates
Benjamin Herrenschmidt
benh at kernel.crashing.org
Mon Oct 28 19:47:01 AEDT 2019
On Fri, 2019-10-25 at 23:39 -0700, Christoph Hellwig wrote:
> On Fri, Oct 25, 2019 at 05:28:45PM -0500, Rob Herring wrote:
> > This doesn't work?:
> >
> > if (IS_ENABLED(CONFIG_PPC) || of_dma_is_coherent(dev-
> > >of_node))
> > value |= ESDHC_DMA_SNOOP;
> > else
> > value &= ~ESDHC_DMA_SNOOP;
> >
> > While I said use the compatibles, using the kconfig symbol is
> > easier
> > than sorting out which compatibles are PPC SoCs. Though if that's
> > already done elsewhere in the driver, you could set a flag and use
> > that here. I'd be surprised if this was the only difference between
> > ARM and PPC SoCs for this block.
>
> I think the right thing is a Kconfig variable that the architectures
> selects which says if OF is by default coherent or incoherent, and
> then use that in of_dma_is_coherent.
That too. We could also define properties for both ways so we can
override the default either way.
Cheers,
Ben.
More information about the Linuxppc-dev
mailing list