Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates
    Benjamin Herrenschmidt 
    benh at kernel.crashing.org
       
    Mon Oct 28 19:45:34 AEDT 2019
    
    
  
On Fri, 2019-10-25 at 17:28 -0500, Rob Herring wrote:
> This doesn't work?:
> 
>         if (IS_ENABLED(CONFIG_PPC) || of_dma_is_coherent(dev-
> >of_node))
>                 value |= ESDHC_DMA_SNOOP;
>         else
>                 value &= ~ESDHC_DMA_SNOOP;
CONFIG_PPC is restrictive. What about sparc64 ? There could be others
.. .we can't suddenly requests people to add new properties for what
was implied behaviours before hand, esp since it's not in the base 1275
spec, no ?
I would suggest of_dma_is_coherent is *true* by default unless
overriden to do something else.
Cheers,
Ben.
    
    
More information about the Linuxppc-dev
mailing list