[PATCH net] powerpc: use big endian to hash len and proto in csum_ipv6_magic
Xin Long
lucien.xin at gmail.com
Wed Sep 12 16:27:38 AEST 2018
On Wed, Sep 12, 2018 at 2:01 PM David Miller <davem at davemloft.net> wrote:
>
> From: Xin Long <lucien.xin at gmail.com>
> Date: Sat, 8 Sep 2018 18:15:12 +0800
>
> > The function csum_ipv6_magic doesn't convert len and proto to big
> > endian before doing ipv6 csum hash, which is not consistent with
> > RFC and other arches.
> >
> > Jianlin found it when ICMPv6 packets from other hosts were dropped
> > in the powerpc64 system.
> >
> > This patch is to fix it by using instruction 'lwbrx' to do this
> > conversion in powerpc32/64 csum_ipv6_magic.
> >
> > Fixes: e9c4943a107b ("powerpc: Implement csum_ipv6_magic in assembly")
> > Reported-by: Jianlin Shi <jishi at redhat.com>
> > Signed-off-by: Xin Long <lucien.xin at gmail.com>
>
> Xin, please address the feedback you were given.
Christophe posted another one,
https://lore.kernel.org/patchwork/patch/983905/
Sorry, I didn't notice netdev wasn't in its CC-list.
More information about the Linuxppc-dev
mailing list