[PATCH net] powerpc: use big endian to hash len and proto in csum_ipv6_magic

Christophe LEROY christophe.leroy at c-s.fr
Wed Sep 12 16:27:32 AEST 2018


Le 12/09/2018 à 08:01, David Miller a écrit :
> From: Xin Long <lucien.xin at gmail.com>
> Date: Sat,  8 Sep 2018 18:15:12 +0800
> 
>> The function csum_ipv6_magic doesn't convert len and proto to big
>> endian before doing ipv6 csum hash, which is not consistent with
>> RFC and other arches.
>>
>> Jianlin found it when ICMPv6 packets from other hosts were dropped
>> in the powerpc64 system.
>>
>> This patch is to fix it by using instruction 'lwbrx' to do this
>> conversion in powerpc32/64 csum_ipv6_magic.
>>
>> Fixes: e9c4943a107b ("powerpc: Implement csum_ipv6_magic in assembly")
>> Reported-by: Jianlin Shi <jishi at redhat.com>
>> Signed-off-by: Xin Long <lucien.xin at gmail.com>
> 
> Xin, please address the feedback you were given.

I submitted an alternative fix, and Lucien Xin gave its Tested-by:

See https://patchwork.ozlabs.org/patch/967868/

Christophe



More information about the Linuxppc-dev mailing list