powerpc/pseries: hcall_exit tracepoint retval should be signed

Michael Ellerman patch-notifications at ellerman.id.au
Fri May 11 00:06:40 AEST 2018


On Mon, 2018-05-07 at 13:03:55 UTC, Michael Ellerman wrote:
> The hcall_exit() tracepoint has retval defined as unsigned long. That
> leads to humours results like:
> 
>   bash-3686  [009] d..2   854.134094: hcall_entry: opcode=24
>   bash-3686  [009] d..2   854.134095: hcall_exit: opcode=24 retval=18446744073709551609
> 
> It's normal for some hcalls to return negative values, displaying them
> as unsigned isn't very helpful. So change it to signed.
> 
>   bash-3711  [001] d..2   471.691008: hcall_entry: opcode=24
>   bash-3711  [001] d..2   471.691008: hcall_exit: opcode=24 retval=-7
> 
> Which can be more easily compared to H_NOT_FOUND in hvcall.h
> 
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
> Acked-by: Anton Blanchard <anton at samba.org>

Applied to powerpc next.

https://git.kernel.org/powerpc/c/8f2133cc0e1f9718f3e2d39b7587f4

cheers


More information about the Linuxppc-dev mailing list