[PATCH] powerpc/pseries: hcall_exit tracepoint retval should be signed

Ravi Bangoria ravi.bangoria at linux.ibm.com
Wed May 9 19:46:09 AEST 2018



On 05/07/2018 06:33 PM, Michael Ellerman wrote:
> The hcall_exit() tracepoint has retval defined as unsigned long. That
> leads to humours results like:
>
>   bash-3686  [009] d..2   854.134094: hcall_entry: opcode=24
>   bash-3686  [009] d..2   854.134095: hcall_exit: opcode=24 retval=18446744073709551609
>
> It's normal for some hcalls to return negative values, displaying them
> as unsigned isn't very helpful. So change it to signed.
>
>   bash-3711  [001] d..2   471.691008: hcall_entry: opcode=24
>   bash-3711  [001] d..2   471.691008: hcall_exit: opcode=24 retval=-7
>
> Which can be more easily compared to H_NOT_FOUND in hvcall.h

Tested-by: Ravi Bangoria <ravi.bangoria at linux.ibm.com>

Thank,
Ravi



More information about the Linuxppc-dev mailing list