[PATCH] powerpc: pseries: use irq_of_parse_and_map helper

Michael Ellerman mpe at ellerman.id.au
Thu Jan 25 17:08:33 AEDT 2018


Rob Herring <robh at kernel.org> writes:

> On Tue, Jan 23, 2018 at 12:53 AM, Michael Ellerman <mpe at ellerman.id.au> wrote:
>> Rob Herring <robh at kernel.org> writes:
>>
>>> Instead of calling both of_irq_parse_one and irq_create_of_mapping, call
>>> of_irq_parse_and_map instead which does the same thing. This gets us closer
>>> to making the former 2 functions static.
...
>> Are you trying to remove the low-level routines or is this just a
>> cleanup?
>
> The former, but I'm not sure that will happen. There's a handful of
> others left, but they aren't simply a call to of_irq_parse_one and
> then irq_create_of_mapping.
>
>> The patch below works, it loses the error handling if the interrupts
>> property is corrupt/empty, but that's probably overly paranoid anyway.
>
> Not quite. Previously, it was silent if parsing failed. Only the
> mapping would give an error which would mean the interrupt parent had
> some error.
>
> Actually, we could use of_irq_get here to preserve the error handling.
> It will return error codes from parsing, 0 on mapping failure, or the
> Linux irq number. It adds an irq_find_host call for deferred probe,
> but that should be harmless. I'll respin it.

OK thanks.

cheers


More information about the Linuxppc-dev mailing list