[PATCH] cxl: Remove function write_timebase_ctrl_psl9() for PSL9

Vaibhav Jain vaibhav at linux.vnet.ibm.com
Thu Feb 15 17:03:42 AEDT 2018


Frederic Barrat <fbarrat at linux.vnet.ibm.com> writes:

> The code change looks ok, but am I the only one to think the commit 
> message doesn't match? The enable bit has always been in the PSL_CONTROL 
> register, it was just badly documented on p8. What's been removed is 
> much of the configuration found in PSL_TB_CTLSTAT.
>
Thanks for pointing this out Fred. I wrongly assumed looking at the PSL8
implementation that writing to the PSL_TV_CTLSTAT regiser enabled the
TB. I will update the patch description and resend the patch.

-- 
Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.



More information about the Linuxppc-dev mailing list