[PATCH] Fix the message in facility unavailable exception
Balbir Singh
bsingharora at gmail.com
Sat Nov 5 15:14:15 AEDT 2016
I ran into this during some testing on qemu. The current
facility_strings[] are correct when the trap address is
0xf80 (hypervisor facility unavailable). When the trap
address is 0xf60, IC (Interruption Cause) a.k.a status
in the code is undefined for values 0 and 1. This patch
adds a check to prevent printing the wrong information
and helps better direct debugging effort.
Signed-off-by: Balbir Singh <bsingharora at gmail.com>
---
arch/powerpc/kernel/traps.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index d26605d..da0f634 100644
--- a/arch/powerpc/kernel/traps.c
+++ b/arch/powerpc/kernel/traps.c
@@ -1520,8 +1520,14 @@ void facility_unavailable_exception(struct pt_regs *regs)
}
if ((status < ARRAY_SIZE(facility_strings)) &&
- facility_strings[status])
- facility = facility_strings[status];
+ facility_strings[status]) {
+ if (!hv && status < 2) {
+ pr_warn("Unexpected facility unavailable exception "
+ "interruption cause %d\n", status);
+ facility = "Unknown";
+ } else
+ facility = facility_strings[status];
+ }
/* We restore the interrupt state now */
if (!arch_irq_disabled_regs(regs))
--
2.5.5
More information about the Linuxppc-dev
mailing list