[PATCH v9 02/26] powerpc/powernv: Cleanup on pci_controller_ops instances

Alexey Kardashevskiy aik at ozlabs.ru
Thu May 5 14:07:43 AEST 2016


On 05/03/2016 03:41 PM, Gavin Shan wrote:
> This cleans up on below data struct instances to use tab instead of
> space indent of statement to avoid complains from scripts/checkpatch.pl.
> No logical changes introduced.
>
>   @pnv_pci_ioda_controller_ops
>   @pnv_npu_ioda_controller_ops
>
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> Reviewed-by: Daniel Axtens <dja at axtens.net>
> Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>


Spaces to tabs conversion is correct, aligning "=" is not to _my_ 
_personal_ _taste_.


Acked-by: Alexey Kardashevskiy <aik at ozlabs.ru>




> ---
>  arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++++++++++++++----------------
>  1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> index c5baaf3..524c9c7 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -3210,31 +3210,31 @@ static void pnv_pci_ioda_shutdown(struct pci_controller *hose)
>  }
>
>  static const struct pci_controller_ops pnv_pci_ioda_controller_ops = {
> -       .dma_dev_setup = pnv_pci_dma_dev_setup,
> -       .dma_bus_setup = pnv_pci_dma_bus_setup,
> +	.dma_dev_setup		= pnv_pci_dma_dev_setup,
> +	.dma_bus_setup		= pnv_pci_dma_bus_setup,
>  #ifdef CONFIG_PCI_MSI
> -       .setup_msi_irqs = pnv_setup_msi_irqs,
> -       .teardown_msi_irqs = pnv_teardown_msi_irqs,
> +	.setup_msi_irqs		= pnv_setup_msi_irqs,
> +	.teardown_msi_irqs	= pnv_teardown_msi_irqs,
>  #endif
> -       .enable_device_hook = pnv_pci_enable_device_hook,
> -       .window_alignment = pnv_pci_window_alignment,
> -       .reset_secondary_bus = pnv_pci_reset_secondary_bus,
> -       .dma_set_mask = pnv_pci_ioda_dma_set_mask,
> -       .dma_get_required_mask = pnv_pci_ioda_dma_get_required_mask,
> -       .shutdown = pnv_pci_ioda_shutdown,
> +	.enable_device_hook	= pnv_pci_enable_device_hook,
> +	.window_alignment	= pnv_pci_window_alignment,
> +	.reset_secondary_bus	= pnv_pci_reset_secondary_bus,
> +	.dma_set_mask		= pnv_pci_ioda_dma_set_mask,
> +	.dma_get_required_mask	= pnv_pci_ioda_dma_get_required_mask,
> +	.shutdown		= pnv_pci_ioda_shutdown,
>  };
>
>  static const struct pci_controller_ops pnv_npu_ioda_controller_ops = {
> -	.dma_dev_setup = pnv_pci_dma_dev_setup,
> +	.dma_dev_setup		= pnv_pci_dma_dev_setup,
>  #ifdef CONFIG_PCI_MSI
> -	.setup_msi_irqs = pnv_setup_msi_irqs,
> -	.teardown_msi_irqs = pnv_teardown_msi_irqs,
> +	.setup_msi_irqs		= pnv_setup_msi_irqs,
> +	.teardown_msi_irqs	= pnv_teardown_msi_irqs,
>  #endif
> -	.enable_device_hook = pnv_pci_enable_device_hook,
> -	.window_alignment = pnv_pci_window_alignment,
> -	.reset_secondary_bus = pnv_pci_reset_secondary_bus,
> -	.dma_set_mask = pnv_npu_dma_set_mask,
> -	.shutdown = pnv_pci_ioda_shutdown,
> +	.enable_device_hook	= pnv_pci_enable_device_hook,
> +	.window_alignment	= pnv_pci_window_alignment,
> +	.reset_secondary_bus	= pnv_pci_reset_secondary_bus,
> +	.dma_set_mask		= pnv_npu_dma_set_mask,
> +	.shutdown		= pnv_pci_ioda_shutdown,
>  };
>
>  static void __init pnv_pci_init_ioda_phb(struct device_node *np,
>


-- 
Alexey


More information about the Linuxppc-dev mailing list