[PATCH v5 07/18] cxl: Update cxl_irq() prototype

Manoj Kumar manoj at linux.vnet.ibm.com
Wed Feb 24 06:13:45 AEDT 2016


Reviewed-by: Manoj Kumar <manoj at linux.vnet.ibm.com>

---
Manoj Kumar

On 2/23/2016 10:21 AM, Frederic Barrat wrote:
> The context parameter when calling cxl_irq() should be strongly typed.
>
> Co-authored-by: Christophe Lombard <clombard at linux.vnet.ibm.com>
> Signed-off-by: Frederic Barrat <fbarrat at linux.vnet.ibm.com>
> Signed-off-by: Christophe Lombard <clombard at linux.vnet.ibm.com>
> Acked-by: Ian Munsie <imunsie at au1.ibm.com>
> ---
>   drivers/misc/cxl/cxl.h | 2 +-
>   drivers/misc/cxl/irq.c | 3 +--
>   2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/cxl/cxl.h b/drivers/misc/cxl/cxl.h
> index 40f6783..c7ed265 100644
> --- a/drivers/misc/cxl/cxl.h
> +++ b/drivers/misc/cxl/cxl.h
> @@ -714,7 +714,7 @@ struct cxl_irq_info {
>   };
>
>   void cxl_assign_psn_space(struct cxl_context *ctx);
> -irqreturn_t cxl_irq(int irq, void *ctx, struct cxl_irq_info *irq_info);
> +irqreturn_t cxl_irq(int irq, struct cxl_context *ctx, struct cxl_irq_info *irq_info);
>   int cxl_register_one_irq(struct cxl *adapter, irq_handler_t handler,
>   			void *cookie, irq_hw_number_t *dest_hwirq,
>   			unsigned int *dest_virq, const char *name);
> diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c
> index 56ad301..5033869 100644
> --- a/drivers/misc/cxl/irq.c
> +++ b/drivers/misc/cxl/irq.c
> @@ -27,9 +27,8 @@ static irqreturn_t schedule_cxl_fault(struct cxl_context *ctx, u64 dsisr, u64 da
>   	return IRQ_HANDLED;
>   }
>
> -irqreturn_t cxl_irq(int irq, void *data, struct cxl_irq_info *irq_info)
> +irqreturn_t cxl_irq(int irq, struct cxl_context *ctx, struct cxl_irq_info *irq_info)
>   {
> -	struct cxl_context *ctx = data;
>   	u64 dsisr, dar;
>
>   	dsisr = irq_info->dsisr;
>



More information about the Linuxppc-dev mailing list