[PATCH] perf record: Limit --intr-regs to platforms supporting PERF_REGS
Jiri Olsa
jolsa at redhat.com
Tue Sep 29 20:47:11 AEST 2015
On Tue, Sep 29, 2015 at 01:30:10PM +0530, Naveen N. Rao wrote:
SNIP
> > > Suka has also posted a fix for this with a different approach [1]. Can
> > > you please ack/pull one of these versions? Building perf is broken on
> > > v4.3-rc due to this.
> >
> > I did not get any answer for additional comments I made to the patch
> > (couldnt get marc.info working, sending the patch again)
>
> Hi Jiri,
> I concur with the changes you proposed to my patch here (getting rid of
> the weak variant):
> http://article.gmane.org/gmane.linux.kernel/2046108
>
> I am aware of the other approach you posted (and the one attached
> below). When I said "please ack/pull one of these versions", I meant one
> of: your version, Suka's and mine.
I was hoping somebody could test it on ppc ;-)
I think the last version (in my last email) that keeps the weak
variable is correct, let's wait for Arnaldo to sort this out
>
> >
> > >
> > > [1] http://article.gmane.org/gmane.linux.kernel/2046370
> >
> > I dont have this last version, which seems to have other changes
> > and patch in above link looks mangled, could you please repost it?
>
> Can you please check the raw version:
> http://article.gmane.org/gmane.linux.kernel/2046370/raw
we have __maybe_unused definition in tools/include/linux/compiler.h
why to redeclare it?
jirka
More information about the Linuxppc-dev
mailing list