[PATCH] arch-powerpc: Return false instead of -EFAULT
Peter Senna Tschudin
peter.senna at gmail.com
Thu Sep 17 19:58:54 AEST 2015
On Thu, Sep 17, 2015 at 11:47 AM, Michael Ellerman <mpe at ellerman.id.au> wrote:
> On Thu, 2015-09-17 at 11:18 +0200, Peter Senna Tschudin wrote:
>> Returning a negative value for a boolean function seem to have the
>> undesired effect of returning true. Replace -EINVAL by false in a
>> bool-returning function.
>> The diff of the .s file before and after the change (using cross
>> compilation) starts with:
>> < .L43:
>> < li 3,1 # D.25775,
>> > .L42:
>> > li 3,0 # D.25775,
>> while if -EFAULT is replaced by true, the diff is empty.
> Ah, that's rather unfortunate.
> Can you post the full asm listing, for all three cases?
Sure, but it would be 3 files of 70kb each. You can download them form:
Let me know if this download method doesn't work for you.
module_64.s: Original file.
module_64-patched.s: With my patch
module_64-true.s: Changing -EFAULT by true
files were made with:
$ make arch/powerpc/kernel/module_64.s
More information about the Linuxppc-dev