[PATCH] arch-powerpc: Return false instead of -EFAULT
Michael Ellerman
mpe at ellerman.id.au
Thu Sep 17 19:47:34 AEST 2015
On Thu, 2015-09-17 at 11:18 +0200, Peter Senna Tschudin wrote:
> Returning a negative value for a boolean function seem to have the
> undesired effect of returning true. Replace -EINVAL by false in a
> bool-returning function.
>
> The diff of the .s file before and after the change (using cross
> compilation) starts with:
>
> 440,441c440,441
> < .L43:
> < li 3,1 # D.25775,
> ---
> > .L42:
> > li 3,0 # D.25775,
> ...
>
> while if -EFAULT is replaced by true, the diff is empty.
Ah, that's rather unfortunate.
Can you post the full asm listing, for all three cases?
cheers
More information about the Linuxppc-dev
mailing list